adsharma

Results 211 comments of adsharma

Agreed that this is a problem. The issue could be that we have many special cases in _visit_AssignOne and they don't behave the same way. Perhaps trying to unify that...

I'm interested in trying kremlin without wasm support. Is there any updated documentation on how to do it?

I wonder if it's feasible to use iterator_traits::reference instead of value_type here: https://github.com/Reactive-Extensions/RxCpp/blob/master/Rx/v2/src/rxcpp/sources/rx-iterate.hpp#L159-L172

> the vector copy would be avoided by passing a non-owning range to iterate. Thanks for the suggestion. ``` - auto values = rxcpp::observable::iterate(vec).skip(size/2).take(size/4); + std::vector sliced = vec |...

The reason why `rxcpp::observable::iterate(sliced)` errors out for me is that include/range/v3/utility/iterator_traits.hpp in range-v3 doesn't define the value_type that rx-util.hpp expects for container types. I'll take another look at isolating the...

Forgot to add the actual error message: ``` /usr/local/rxcpp/rx-util.hpp:35:80: error: no type named ‘value_type’ in ‘std::decay::type {aka struct std::iterator_traits}’ template using value_type_t = typename std::decay::type::value_type; ```

That change does fix it. Thanks! Re: Using range-v3 for vectors and rxcpp for streaming Things get a bit complicated when a common optimization called "microbatching" is applied. The idea...

> are you referring to the buffer operators? Yes. Glad to know rxcpp already takes care of it. I was looking into the implementation here: https://github.com/Reactive-Extensions/RxCpp/blob/master/Rx/v2/src/rxcpp/operators/rx-buffer_count.hpp#L92 and was wondering if...

Using the @sealed decorator derived from the `adt` library makes it around 4-5x slower than the Java derived version. Likely because of all the `isinstance()` checks inside the libary. Need...

Certainly OO programming is widely used and should be proportionately represented. I feel the following are underrepresented: * Use of dataclasses * Generalized Algebraic data types, functional programming techniques. Usage...