adsharma

Results 211 comments of adsharma

Modified the networkx PCG solver to use cupy. It works, but is not faster. https://github.com/adsharma/nx-spectral-ordering/compare/f2073213a8984e2db4816f1cfa21d61fd0402531..7104b1d74139875bab500652b316d1e6ad06995b Still interested in exploring if cuSparse PCG solver is a better solution.

I wrote a [PCG solver using triton](https://github.com/adsharma/triton-pcg-solver). It's not very fast, but seems to pass correctness tests. This [branch ](https://github.com/adsharma/nx-spectral-ordering/tree/triton) has the networkx code modified to use the PCG solver....

@svlandeg I think there were some merge errors in one of the commits in this thread. The following should show changes to only `sqlmodel/main.py`. However, I see other deltas. ```...

> The diff on this PR only shows changes in sqlmodel/main.py That's the inconsistency I'm calling out. What the UI shows and `git diff commit1 commit2` show are different and...

I looked into the `pydantic_v1` test failures a bit. There are 3 different instances of the test: ``` ~/src/sqlmodel/docs_src/tutorial/fastapi/app_testing$ ls -1d tut* tutorial001 tutorial001_py310 tutorial001_py39 ``` If I run pytest...

@svlandeg the above test run verifies that the pydantic-v1 breakage was caused by my change. Looking into the actual cause of the failure, I think there is some `__call__` magic...

@svlandeg tests are all green. Please review.

@YuriiMotov here's how I would like this work to be viewed: > The most general case is using meta programming to hide implementation details behind `Pydantic` and `SQLModel`. In a...

> But in current implementation (this PR) initialization is not deferred, right? It just allows to re-initialize model later. That's right. But this [file](https://github.com/adsharma/fquery/blob/main/fquery/sqlmodel.py) works as a standalone library. If...

> dynamically add fields using decorators yes, this is a valid use case. So are stacking other decorators: ``` @node @sqlmodel class SomeModel: ... ``` Would allow this table to...