Adrian Schmutzler

Please choose one of the two Signed-off-by lines and drop the other one.

Ping.

> Had to increase the 2.4G wifi mac address by one (WAN + 3 now, otherwise it clashed with wlan5g) > Interfaces: > > eth0: 20:0d:b0:7a:e6:c1 (LAN) > eth1: 20:0d:b0:7a:e6:c0...

Please bump PKG_RELEASE in Makefile.

You misunderstood this. Please create another dtsi with contents of current qca9563_tplink_tl-wpa8630-v1.dts minus compatible/name. The -v1.dts and *p-v1.dts will then inherit from this dtsi and only contain the model/compatible. Apart...

Content is fine. But the commit message is a mess. Please replace it by a proper commit message for supporting a new device, i.e. including Specifications and Flashing instructions.

> Installation: > > I have not a new device to test flashing from factory image. Are you serious?

This still needs to be squashed into a single proper commit; the commit title is still not correct, please simply use the title of the PR instead. Apart from that,...

I'm a huge fan of this idea. I only had a quick look for the moment. Personally, I think we could improve the folders/hierarchy/organization, I'd rather do something like meta/schemas...

> sence of any other information, having at least the values from the PSU is superior that having nothing at all. Well, mixing different kinds of information without a clear...