Adrian Schmutzler

Looks like the first commit does three different things, so it should be three commits then.

> As mentioned earlier, this device was supported in ar71xx already, thus the LED migration: > > > LED behaviour is a little awkward with both configured to WAN activity,...

Missing commit message for the first three patches. Is the final patch supposed to be squashed?

Picked the first commit for now.

> ath79: Replace reset-button, spi-max-frequency increase These are two changes, please make them two separate commits. > Merge branch 'master' into master Please remove the merge commit (i.e. squash the...

> spi-max-frequency increased to 50000000 Please don't write down the obvious but explain why this can be done (in the commit message). And please be specific in your commit title,...

MAC address setup for ethernet is missing. Flashing instructions are missing. Is the address in the commit message really 192.169.0.1 and not 192.168.0.1? Please group together the specification details in...

There is still no justification at all for the reset-gpios change ...

@s-2 Could you just put together a proper patch for that with a meaningful commit message and either link it here or e-mail it to me so I can directly...

If I remember correctly, the wifi startup somehow happens asynchronously and you simply cannot depend on it during procd startup. That's why you have to rely on these hotplug.d scripts...