Adrian Schmutzler

Results 91 comments of Adrian Schmutzler

Indeed. This whole project looks quite dead to me?

Small update: When I keep Visual Studio open and Team Explorer there logged in to the relevant project, I still get the Microsoft Sign-In popups but they don't require any...

@siprbaum Big update: I've narrowed down the issue to the GitRepository.ReadAllTfsRemotes() function: https://github.com/git-tfs/git-tfs/blob/master/src/GitTfs/Core/GitRepository.cs#L127-L134 This one goes through all GitTfsRemote objects (one per "branch"), and in my case needs re-auth for...

> It's been a while since I've been in the code, but I wonder if TfsHelper could be a singleton per URL+username+password, rather than a new instance per GitTfsRemote? I...

Your commit message lacks flashing instructions.

Please provide flashing instructions that explain the process in a way that somebody who does not already know what to do can do it.

Second and third patch lack Signed-off-by. Third patch doesn't need to have device-name twice in it, apart from that it's not device-specific anyway (and should be reworked to be specific...

You should probably split out more of the kernel patches from the device support commit (unless they are directly related like the DTS ...).

Please squash all changes together into a single proper commit (and wrap the long lines in the commit message) ...

So, now you have a merge commit again ...