Adrian Price-Whelan
Adrian Price-Whelan
@saimn given the analogy to the many "badges" in the README, are you still uncomfortable with the image appearing on pypi? I think this is the final point in the...
I personally think the visibility this would have in the README outweighs the small inconsistency this would represent when appearing on pypi (i.e. that the image would always be current)....
The point of this PR is the addition of the stats -- the README edits are minor. If people want to discuss this more, please do it here. I think...
@jeffjennings - it looks like GitHub markdown does support light/dark mode detection (e.g., [here](https://www.stefanjudis.com/notes/how-to-define-dark-light-mode-images-in-github-markdown/)), so could you use that feature here? Also, thinking about this again, I think the banner...
Given that the vote above was close, I asked @astropy/coordinators to advise on this PR. (FYI: The failing coverage check is an error and not relevant, I think)
I think potentials, circular_velocity/mass_enclosed, streams, and documentation/tutorials!
We know @TomWagg over here and I'm sure he'd be happy to chat :).
I'm fine with `r_s`, but other options: `r0`, `a`, `scale_radius`. I kinda like not having an underscore but don't have very strong feelings!
Haha I think given all that, I'm fine with `r_s`. I still like `scale_radius` for clarity. But we are a little inconsistent with abbreviations elsewhere. For example, `t` vs `time`....
I didn't look in detail to see if it's a copy-paste, but if so, can you take along the git history from Gala? They are a bit out of date...