Adrien Vergé

Results 362 comments of Adrien Vergé

Hi @ocombe! Sorry to get on this again... But I think it could be a real improvement for teams that use long strings in their Angular projects 🙂

Hi @ocombe, sorry to get back on this again. We have to manually patch i18n-polyfill after each `npm install` (using this PR), otherwise we can't use it on our project...

The problem also happens for invocations with strings (not `I18nDef`): ```ts this.i18n('My ' + 'value'); ``` I propose a simple fix at #50.

Thanks for feedback @ljharb @goatslacker. > in the case of your example, where "port" needs to be a positive integer, opts.port || 80 is actually more accurate That's true, `port`...

> Separately, is there an eslint rule that would enforce this? I did not see any rule like that. It would be hard to enforce, since `||` is legitimate in...

> the idea would be to always disallow `||` in assignments, not just nullable values. Actually what I proposed was less strict: disallow `||` for defaulting, i.e. do not use...

@ljharb Absolutely. But in my opinion, not being able to enforce it does not mean we shouldn't recommend it.

Hi, I don't understand your question.

Hello, If I undestand correctly, you would like yamllint to read its configuration from a file `setup.cfg` in current directory, if present? This seems very Python-specific. Although yamllint is written...

Hello Dimitri, thanks for these contributions! 1. I'm not sure about the first commit, is it worth complexifying the code, given that the generator here is well known (it comes...