adrienverge
Implemented moving pictures within their frame
Nice, thanks for this feature!
However, I don't like the activation via Ctrl: it is an easter egg that is very hard to discover.
What about merging SWAPPING and MODIFY_PICTURE_OFFSET in a single MOVING mode, and take the appropriate action on mouse up?
Having this feature is great.
Why not merge as is, so the user at least has the option to move the pic in the frame, then in a separat new issue merge swapping and moving?
@jdavidberger is it possible to zoom in/out as well?
Why not merge as is
Because it's best to avoid changes in user interfaces. On non-beta software, users don't want to start using a feature, then get lost because it is not accessible the same way anymore (for instance with Ctrl).
Plus, the change I ask is relatively easy :)
is it possible to zoom in/out as well?
I agree this would be very nice! (But this can go in another pull request.)
I'll see if I can get to it this week. It isn't a difficult modification; the only reason I didn't do it like this originally was in an effort to not effect existing behaviors.
It would be nice, long term, to see something like redraw on mouse move. The current render loop is somewhat incompatible with that; I think you'd have to do away with the 'rendering' pop up and probably also try to have it only draw the one cell that needed it to scale well with big collages.
On Thu, Dec 29, 2016 at 1:31 AM, Adrien Vergé [email protected] wrote:
Why not merge as is
Because it's best to avoid changes in user interfaces. On non-beta software, users don't want to start using a feature, then get lost because it is not accessible the same way anymore (for instance with Ctrl).
Plus, the change I ask is relatively easy :)
is it possible to zoom in/out as well?
I agree this would be very nice! (But this can go in another pull request.)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adrienverge/PhotoCollage/pull/39#issuecomment-269597566, or mute the thread https://github.com/notifications/unsubscribe-auth/AH0LCySzAXtsMEPOgDalk_PqU4XbApEQks5rM2_bgaJpZM4LVUK_ .
Sorry, this was automatically closed because of "fix #39" in @frankMilde pull request #41.
Reopening.
@jdavidberger I'd love to have this feature! Please, if you changed the event condition already, could you please share it?
