adrienpoly
style a bit the stamps
yeah the design is clearly inspired by Helm. Ok I understand better the concept of sticker vs stamps. What confused me at first was maybe the initial design with the border that was somehow looking like a passport border.
I think this design integrates better into the current style of the app (IMHO). Maybe we could :
- remove the dark border that mimic a passport
- replace stamps collected by sticker collected
Once we have Stamps create another page/tabs for that. But I think this is really another complete new subject as creating/assigning those stamps seems like a lot of things to do
I guess we lost some of the laptop esthetic when I copied it from the /stickers page to the speaker profile tab:
But yeah, agreed, the laptop layout isn't ideal as it is right now, especially on the way it looks on mobile. So yeah, maybe we can arranged the stickers on the profile in a more grid-like way like you did here in this PR.
got it ! I didn't understood it was a Mac with sticker probably du to the form factor being very different in the tab.
Going off topic here but most probably we will want to change the navigation. On some profiles this give I think too much tabs.
Maybe one tab only for videos but with filters so that we can select the kind of talk rather than having all those tabs for Q&A etc
We are using the design from this pull request in https://github.com/rubyevents/rubyevents/blob/93317aad825e6639d03c305e33ac3f710f0b06e6/app/views/shared/_stamps_grid.html.erb, so we can close this one.