rubyvideo icon indicating copy to clipboard operation
rubyvideo copied to clipboard

Filter speakers

Open grassiricardo opened this issue 8 months ago • 10 comments

Hello,

What think create then filter speakers for speaker in then url: https://www.rubyevents.org/speakers

I want will go to implement this filter. Its possible?

grassiricardo avatar Apr 09 '25 12:04 grassiricardo

Hey @grassiricardo, yes that sounds great!

We haven't really done a lot of filters to far. What kind of filters were you thinking of?

I know @adrienpoly did add some filters to the backend-side for talks here: https://github.com/rubyevents/rubyevents/pull/433 and I dabbled with it for talks here too: https://github.com/rubyevents/rubyevents/pull/384

marcoroth avatar Apr 09 '25 16:04 marcoroth

Hey @marcoroth, I think filter the speakers, name of speakers only. Only textfield, basic.

grassiricardo avatar Apr 09 '25 16:04 grassiricardo

There is already a search on the speaker name. You can open it with cmd+k or click on the search icon.

Image

If you didn't noticed it them maybe we have an UX issue and it should be more visible?

adrienpoly avatar Apr 10 '25 05:04 adrienpoly

@adrienpoly I actually left the filter unobserved, I tried to find a filter just above the listing, which is more common for me, maybe we have some UX problem in this regard.

grassiricardo avatar Apr 10 '25 13:04 grassiricardo

@marcoroth what is you plan for adding search to the mobile app? It is currently disabled as far a I could tell. I think we should coordinate so that we mutualise the effort

The cmd+k search is a global search. I think it could make sens to have a dedicated search field more visible on the speaker page (this can be then duplicated on the topics/events pages) to perform full text search.

The search endpoint is already available, I think a lot of what we have for the spotlight search can be reused for that unless we want a completely different display of the suggested results

adrienpoly avatar Apr 11 '25 05:04 adrienpoly

I intentionally left out the search for the MVP version of the mobile app, but yeah, I think it's quite an important feature to have and we should make sure to reuse what we already built.

marcoroth avatar Apr 11 '25 06:04 marcoroth

do you plan to make it native or web base ?

adrienpoly avatar Apr 11 '25 06:04 adrienpoly

If necessary, I can will help this filters.

grassiricardo avatar Apr 11 '25 12:04 grassiricardo

sure feel free to explore this and open a PR

adrienpoly avatar Apr 12 '25 06:04 adrienpoly

OK, I will try

grassiricardo avatar Apr 16 '25 01:04 grassiricardo