rubyvideo icon indicating copy to clipboard operation
rubyvideo copied to clipboard

Sort speaker talks by date

Open nicogaldamez opened this issue 1 year ago • 4 comments

When I visit a speaker’s page, it’d be nice to see talks ordered by date with the most recent at the top and the oldest at the bottom.

Right now, this is what a user see: image

nicogaldamez avatar Nov 05 '24 20:11 nicogaldamez

yes good idea

adrienpoly avatar Nov 05 '24 20:11 adrienpoly

The talks are actually ordered from most recent to oldest. In this case it's bad data for some of the conferences, since it's using the published_at field which is off by a few years.

https://github.com/adrienpoly/rubyvideo/blob/aff996bde8a75fcee936c8a0b99c024df6b8c1c5/app/controllers/speakers_controller.rb#L24

marcoroth avatar Nov 05 '24 21:11 marcoroth

If it's just bad data, we can close this issue. What do you think?

nicogaldamez avatar Nov 29 '24 11:11 nicogaldamez

@nicogaldamez Technically yeah, unless we make sure to resolve all the bad data first 😅

At least we now have an actual idea how many talks still have bad data in the "Review Talk Dates" tab https://www.rubyvideo.dev/contributions

(for the contributions: I guess we should also have a way to link to a specially link to one of the pages)

marcoroth avatar Nov 29 '24 12:11 marcoroth