medusa-extender icon indicating copy to clipboard operation
medusa-extender copied to clipboard

feat: Add support for medusa 1.8 @next

Open adrien2p opened this issue 1 year ago • 7 comments

WIP

adrien2p avatar Feb 28 '23 11:02 adrien2p

Is this PR ready to merge? I can help test.

Arsenalist avatar Apr 07 '23 04:04 Arsenalist

I have been testing this since yesterday with latest Medusa 1.8 and Extender 1.8.8, and unless you're using custom repositories, everything seems to work.

I am using pretty much all aspects of extender and the only issue I ran into with was cases where I was overrriding repositories, where I got compilation errors in the index.d.ts files. I have removed custom repositories and instead get the repository using TypeORM directly like this now:

em.getRepository(MyCustomProduct)

This seems to work fine.

The other issue is that extender still depends on older TypeORM which fails npm i but using npm i --force installs fine. I'm assuming that we'll be updating extender to use TypeORM 3 in the next release, and when that happens things should be good.

Great work on this!! Extender has made my life a lot easier.

Arsenalist avatar Apr 07 '23 15:04 Arsenalist

Thanks a lot 🙏 the extender will be deprecated and we are writing a migration guide to move to a full medusa set up. I keep this pr open for those who are in needs of a smooth transition 😅 hope that's fine for you.

adrien2p avatar Apr 12 '23 14:04 adrien2p

Hello folks, first off thank you for a great repo, I was trying to follow a previous guide in Medusa blog about how we can create a marketplace by leveraging medusa-extender, but now it looks like this is being deprecated.

Does that mean if we are using medusa 1.8+, these extensions can be build on top of medusa itself? Any information regarding how we can proceed here will be very helpful. thank you in advance.

mein-beer-hu avatar May 24 '23 03:05 mein-beer-hu

Hello @adrien2p , Is there an ETA on migration guide. We have alot of custom repositories we'd like to keep but running into compile time issues when upgraded to MedusaJS 1.8.1

mewulonu avatar Jun 07 '23 11:06 mewulonu

you can try to use @sgftech/medusa-extender as a stop-gap arrangement if you are not ready to migrate yet

On Wed, 7 Jun 2023 at 16:33, Mitchell Ewulonu @.***> wrote:

Hello @adrien2p https://github.com/adrien2p , Is there an ETA on migration guide. We have alot of custom repositories we'd like to keep but running into compile time issues when upgraded to MedusaJS 1.8.1

— Reply to this email directly, view it on GitHub https://github.com/adrien2p/medusa-extender/pull/181#issuecomment-1580538994, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXEQJHEEQIZN3MW6J3IL5QDXKBNX7ANCNFSM6AAAAAAVKS25VM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

--

This message (including any attachments) may contain confidential, proprietary, privileged and/or private information. The information is intended to be for the use of the individual or entity designated above. If you are not the intended recipient of this message, please notify the sender immediately, and delete the message and any attachments. Any disclosure, reproduction, distribution or other use of this message or any attachments by an individual or entity other than the intended recipient is prohibited.   

SGFGOV avatar Jun 07 '23 11:06 SGFGOV