Adrien de Peretti

Results 190 comments of Adrien de Peretti

@pKorsholm could you update the types in the entity as well please 😊

@pKorsholm could we add an integration test for that please :)

Also, @dwene @olivermrbl that pr https://github.com/medusajs/medusa/pull/1894 will probably fix some issues as well around transaction and wrong object usage. Might not fix everything but it could help

It is probably related to the work I told you about here https://github.com/medusajs/medusa/pull/1773 https://github.com/medusajs/medusa/pull/1776 https://github.com/medusajs/medusa/pull/1780 https://github.com/medusajs/medusa/pull/1781 https://github.com/medusajs/medusa/pull/1789 https://github.com/medusajs/medusa/pull/1790

> we should also consider `reset-password` The idea is that the default reset-password is part of the core, but if a user create a strategy that require a reset password,...

> LGTM - I am happy to include this PR as it is now, but I would like to discuss this with a wider group before we move forward. >...

I have also suggested to look into the indices usage after analysing the queries since depending on the query an index can end up not being used and therefore slow...

@srindom it seams from my understanding that it is happening when they are swapping lines items, they remove and add lines. @srindom I think you've worked on bulk update no?

@dwene also, depending on your tests it might be worth looking on the database capabilities, memory, cpu etc to see if there is a sizing problem as well and remove...

Can you give us the diff between the schemas