Adrien de Peretti

Results 190 comments of Adrien de Peretti

> > if you want to also throw an eue on it > > Just adding that we are aiming to run tests early next week before merging it in...

@olivermrbl do you think that pr could be merge at some point?

@olivermrbl I ve open a pr in the CORS repo as I can't seam to be able to find the culprit https://github.com/expressjs/cors/issues/292 It is also possible that the changeset need...

It is now working properly, just need to double the \ to avoid them to be escaped `/http:\\/\\/localhost:700\\d+$/`

> That's a great functionality. > > Question: I believe we will increase quite a lot the size of the plugins if they now depend on medusa core. Should we...

on hold for now till I come up with something for the naming (already got an idea, need to test it out)

> There is an additional reason for creating `findWithRelations`. We encountered OOM errors when the default TypeORM query, could imagine the reason being that there was an enormous amount of...

Also, another interesting point is that we are using `find` in the list method and the custom one in the `retieve`. I would have assumed that the `list` method would...

Since newer version of typeorm, it is now possible to specify the loading strategy - relationLoadStrategy https://github.com/typeorm/typeorm/pull/8616 Of course there is few breaking changes but nothing we can't tackle i...