Adrien de Peretti

Results 216 comments of Adrien de Peretti

> If you consider upgrading mikroorm to version ^6.5.0 you could also use the balanced loading strategy per default which seems to give the best results out of both. We...

> Yes, added the changes to the type as per Adrien suggestion, though that introduces the issue I mentioned in my last comment when we don't pass the types and...

> > thanks man 🎉 should we add a new integration tests that filters with summary total on the order? > > hey @adrien2p , I addressed the feedacks, is...

> > Should we also check other modules that are using currency_code? this pr primarely focuse on the pricing and it might be the objective but just want to throw...

> @adrien2p With the latest update i did to the test, this would now be breaking right? Since existing filters using `index.graph` that have an uppercased `currency_code` will no longer...

> Hey ! Could you expand on the reason ? For now it is an experiment, but mainly reducing circular deps references preventing moving to am later (one of the...

hey @chuxi, just to be sure, you fixed it by adding `LinkProductShippingProfile` to your generated types? Cause on my side I have it properly

cc @shahednasser , maybe we need to adapt the documentation :)

> @adrien2p can you clarify exactly what should be adapted? Because the changes seem to be under the hood rather than user-facing. > > If you mean anything related to...