Adrian Marin

Results 349 comments of Adrian Marin
trafficstars

What if the table is empty from the filters selaection? How would one reset the filters?

Can we add some tests to this too? They can be modeled after our current ones.

Hey @dhnaranjo. Thank you for your contribution. This is a great addition, and it's definitely something we want to support going forward. Let me have a look this week and...

Hey @dhnaranjo. Thanks for all the work! I'd love it if we had a switch somewhere between pundit and AP (maybe `configuration.rb`). I'm open to auto-detect the gem used, but...

I know what you mean and appreciate you thinking about the best method to test it. Usually, I would use the same strategy, but with Avo, we rely a lot...

Yes, I'm thinking about it too. Can't we actively re-apply the monkey patch in the test's `before` block? Spitballing here.

@dhnaranjo how about generating separate gemfiles using [Appraisal](https://github.com/avo-hq/avo/blob/main/Appraisals)? So then we'd add one more level to the [test matrix](https://github.com/avo-hq/avo/blob/main/.github/workflows/test.yml). `action_policy` and `pundit`. That will have the tests passing in the...

Hey @dhnaranjo. I'm open to that, as long as we can **really** test every behavior. Even the more advanced ones like `act_on?` (actions authorization), `create_comments`, `attach_members?` (associations), `download_file?` (files), etc....

Thanks for getting back to us with this 🙌 That's actually a bug. So the action you are showing is disabled because you haven't selected any records. I you want...

> Ok, and is it possible to have an action that runs on the entire table? > > This is somewhat related to #1248 Or the alternative is to create...