Adrian Mróź

Results 113 comments of Adrian Mróź

Are those measures visible in left-side panel?

I can't spot any issue in the code. I will try to reproduce this on my instance and see what happens. So you have config with empty measures section, few...

So let me get this straight: 1. Few measures in `measures` section (let's call them defined measures). Rest of discovered via inspection (let's call them discovered measures). 2. You see...

Sorry, I couldn't replicate your issue. I even see that objects passed to left panel and expression dropdown are the same. Only filtering is here: https://github.com/allegro/turnilo/blob/master/src/client/components/series-menu/arithmetic-series-menu.tsx#L108 Are you sure, your...

I can't format that way with either version of numbro.js. Sadly, I don't think we can do anything about it - I don't see any other library that handles your...

But wouldn't you need to multiply your input by 8? input: `16` formatter: `2B` custom symbol: `2b` But you wan't to get `16b`. Anyways, we had some plans for better...

Let's extract bug fix to another PR, so we could merge it earlier. Rest of it should wait till we discuss what is needed and how we should achieve it....

Thanks for this PR! I will go today with code review and in next week we discuss this feature on team meeting. Idea looks great but I'm not sure about...

You can run `npm run lint` locally to check for listing errors.

Before we will shuffle components around we should discuss how we want UI to look.