Adrian comments

Results 25 comments of


                                            Adrian

Create a generic form

I have taken a look at how hooks in the wild and this was a more common use case than having all dependencies in one array: ```javascript useCustomHook(funcA, depsA, funcB,...

Rules for property accesses

Idea: When accessing `.current` on a variable, it must be explicitly labelled or inferred to either be a ref or a non-ref. Assignment to `useRef` would automatically label it as...

Rules for property accesses

If the default behavior is to add the object to dependencies and show a warning, it would probably not break a lot of code.

Rules for property accesses

**The algorithm** - If `.current` is accessed in the scope or child scope of an auto hook - Find its highest parent (`foo.bar.current` -> `foo`) - Determine status of highest...

Some important things to consider is conditionals, `this`-context and impure getters. This contrived example: ```javascript const [config, configure] = useState() const ref = useAutoCallback(element => { configure({ actions: { click()...

chore(package.json): Changed react version in peerDependencies to acc…

You should probably squash the commits in the PR.

Offsets are wrong when container is scaled

Same here. Not a major issue for me, but a minor annoyance. What about adding support for a prop named scaleFactor?

Allow disabling ports (for merging multiple compose files)

This could be done in `compose/config/config.py` in `process_ports` I believe. New to the code base and my Python is getting rusty.

pm2 monit crashes

I submitted a PR to blessed to resolve this issue. https://github.com/chjj/blessed/pull/439