pgpq icon indicating copy to clipboard operation
pgpq copied to clipboard

Add Struct column support

Open jpfeuffer opened this issue 9 months ago • 4 comments

Regarding #5 Simple try to get started with a "dummy oid" solution. Compiles but most likely is still missing quite some stuff. It is also not tested yet although I started adding code for generation of a very simple test input.

jpfeuffer avatar Mar 09 '25 23:03 jpfeuffer

@adriangb Do you have any comments on the general approach?

I might have a bit of time next week to continue on this. Sorry I think I did not setup formatting yet.

jpfeuffer avatar Mar 21 '25 08:03 jpfeuffer

Linting apparently fails because of pyo3 being too old for newer/stricter rust versions -> Blocked by #43

jpfeuffer avatar Jun 15 '25 10:06 jpfeuffer

Maybe we should add some tests for interactions between list and struct. Otherwise good to go.

jpfeuffer avatar Jun 15 '25 10:06 jpfeuffer

Yes I agree with all the points. I will try to address them soon. Regarding CI, yes, I just realized too late that it was not running and at that point should have fixed CI first. Maybe if we merge your new CI fixes first and then I merge that into this branch? Won't get rid of the commits but the diff will be smaller.

jpfeuffer avatar Jun 15 '25 15:06 jpfeuffer