spigo icon indicating copy to clipboard operation
spigo copied to clipboard

Collect and save/process histograms of response times

Open adrianco opened this issue 9 years ago • 7 comments

Tweaked hdrhistogram configuration to use much less memory. Changes to metrics package to export histograms - need to make a pull request for codahale/metrics Collect histograms for response time (zipkin cr-cs) and service time (zipkin ss-sr) as well as network delay (zipkin sr-cs was the initial implementation, cr-ss).

Save time distributions in the json graph when a node exits.

adrianco avatar Dec 26 '15 17:12 adrianco

nice!

On Sat, Dec 26, 2015 at 9:48 AM, Adrian Cockcroft [email protected] wrote:

Tweaked hdrhistogram configuration to use much less memory Changes to metrics package to export histograms - need to make a pull request for codahale/metrics Collect histograms for response time (zipkin cr-cs) and service time (zipkin ss-sr) as well as network delay (zipkin sr-cs was the initial implementation, cr-ss)

Save time distributions in the json graph when a node exits

— Reply to this email directly or view it on GitHub https://github.com/adrianco/spigo/issues/59.

hubayirp avatar Dec 27 '15 01:12 hubayirp

I'm working with the author of Guesstimate to figure out a way to feed spigo models to it. A hand created example of what that might look like is here: http://getguesstimate.com/models/1307

The project is https://github.com/getguesstimate/guesstimate-app

adrianco avatar Jan 05 '16 20:01 adrianco

Updates made to codahale/hdrhistogram and pull request accepted, so now distributions can be extracted from the histogram.

Switched from codahale/metrics to go-kit/kit/metrics and submitted pull request for extvars to use updated hdrhistogram to save distributions.

Changed flow and collect and denominator, needs some more cleanup before updating github.

adrianco avatar Feb 01 '16 01:02 adrianco

Even more Go friendly - nice! On Sun, Jan 31, 2016 at 5:29 PM Adrian Cockcroft [email protected] wrote:

Updates made to codahale/hdrhistogram and pull request accepted, so now distributions can be extracted from the histogram.

Switched from codahale/metrics to go-kit/kit/metrics and submitted pull request for extvars to use updated hdrhistogram to save distributions.

Changed flow and collect and denominator, needs some more cleanup before updating github.

— Reply to this email directly or view it on GitHub https://github.com/adrianco/spigo/issues/59#issuecomment-177691509.

hubayirp avatar Feb 01 '16 02:02 hubayirp

Implementation complete and code updated - see collect package. Now uses go-kit/metrics which was updated to allow histograms to be extracted and printed Updates were also made to codahale/hdrhistogram to allow histogram distributions to be exported Interface added to guesstimate (see github.com/adrianco/goguesstimate for implementation) which allows distributions to export a file for upload to getguesstimate.com

adrianco avatar Feb 05 '16 15:02 adrianco

Nice find!

On Fri, Feb 5, 2016 at 7:25 AM, Adrian Cockcroft [email protected] wrote:

Implementation complete and code updated - see collect package. Now uses go-kit/metrics which was updated to allow histograms to be extracted and printed Updates were also made to codahale/hdrhistogram to allow histogram distributions to be exported Interface added to guesstimate (see github.com/adrianco/goguesstimate for implementation) which allows distributions to export a file for upload to getguesstimate.com

— Reply to this email directly or view it on GitHub https://github.com/adrianco/spigo/issues/59#issuecomment-180399978.

hubayirp avatar Feb 05 '16 18:02 hubayirp

Beats DataHero!

On Fri, Feb 5, 2016 at 10:09 AM, priya joseph [email protected] wrote:

Nice find!

On Fri, Feb 5, 2016 at 7:25 AM, Adrian Cockcroft <[email protected]

wrote:

Implementation complete and code updated - see collect package. Now uses go-kit/metrics which was updated to allow histograms to be extracted and printed Updates were also made to codahale/hdrhistogram to allow histogram distributions to be exported Interface added to guesstimate (see github.com/adrianco/goguesstimate for implementation) which allows distributions to export a file for upload to getguesstimate.com

— Reply to this email directly or view it on GitHub https://github.com/adrianco/spigo/issues/59#issuecomment-180399978.

hubayirp avatar Feb 05 '16 18:02 hubayirp