Adrian Chiris
Adrian Chiris
/test-e2e-nvidia-all
LGTM from my sided. just needs rebase
> but the second part `gc component can be extended to clean up NodeFeature objects for nodes that are not intended to run nfd-worker pods` How will GC know which...
> I would prefer to go for something like finalizers initially and check if that's enough. Having an annotation that the GC can read, and if present, not remove the...
> For the possible GC improvements (if we need/want it), could we exploit the owner refs for that, too. E.g. see if the owner pod of NF exists, if not,...
> Makes sense? yes it does, thx.
@maiqueb @dougbtv thoughts on this one ?
depends on: https://github.com/vishvananda/netlink/pull/1115
https://github.com/vishvananda/netlink/pull/1115 was merged. work can be resumed on this MR
lgtm