angularfire2-offline icon indicating copy to clipboard operation
angularfire2-offline copied to clipboard

#35 WIP: try to use child_added event to avoid updating whole array for single item being added

Open ciekawy opened this issue 7 years ago β€’ 2 comments

DO NOT MERGE This is just a try/proposal for https://github.com/adriancarriger/angularfire2-offline/issues/35 to use array item level events to avoid all items being updated each time

any comments, suggestions, ideas, commits are welcome.

currently this is not even yet tested on any projects, just tests are passing

ciekawy avatar May 17 '17 16:05 ciekawy

Codecov Report

Merging #37 into master will decrease coverage by 3.88%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage    97.8%   93.92%   -3.89%     
==========================================
  Files           6        6              
  Lines         319      329      +10     
  Branches       45       46       +1     
==========================================
- Hits          312      309       -3     
- Misses          7       20      +13
Impacted Files Coverage Ξ”
src/database/database.ts 85.5% <33.33%> (-9.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update e772ad9...8087d21. Read the comment docs.

codecov-io avatar May 17 '17 16:05 codecov-io

I really like what I see so far! This should make list updates much more efficient. Thanks for putting this together πŸ‘

adriancarriger avatar May 21 '17 12:05 adriancarriger