Adrian Benavides

Results 46 comments of Adrian Benavides

We have to reenable the tests we ignored on this [PR](https://github.com/build-trust/ockam/pull/5292) once we have a way to replace the `1.node.ockam.network:4000` node.

Hi @YorickdeJong ! It's still open, yes, but we still don't have a way to replace the old `1.node.ockam.network:4000` node address.

The node with the address `1.node.ockam.network:4000` used to be a test node in our old system a few months ago, but it's no longer available. The problem is that we...

Hello @YorickdeJong ! I'll be reviewing your PR, nazmul is not available until next week. To make things easier on our side, could you: - Squash your commits into a...

> Thanks! Will take a look in about 1-2 days if that's ok :) Sure, whenever you can. Thanks 🙏

Btw, you need to open a separate PR to accept the contributor's license agreement, otherwise, we won't be able to merge your PR. > I have read and accepted the...

Looks good. We need to do some cleanup of the commits before we can proceed: - You need to squash all commits into a single one. You have some merge...

I've done some small modifications to the PR to make the CI checks pass, but there is an issue with `termbg` and we need to wait until the following PR...

Will get merged through https://github.com/build-trust/ockam/pull/7731 Thanks again @YorickdeJong for your help with this one!! 🙏

Hi @CBenoit , I opened this PR https://github.com/tokio-rs/tracing/pull/3026 trying to do a similar thing, then I realized your PR was doing a better job and I closed mine to concentrate...