Shad Amethyst
Shad Amethyst
I'd like to tackle this issue.
Re: I find the current implementation of PStrs quite convoluted; it relies on: - sentinel values (which causes a lot of headache when the string contains one or more null...
This looks good to me as is. I do agree with Markus' suggestion to add a wordful explanation of the possible usages of `append/3`; something like: ``` This predicate can...
It's a compromise between performance and safety, mainly. Defragmentation was already possible beforehand, but it required going through the heap to modify any affected `Atom`, and ensuring that any operation...
The rebase to `rebis-dev` shouldn't be too hard
I'm not sure why `AndFrame::index` behaves like a 1-indexed array, but I've added assertions in `stack.rs` where they were easy to add, and otherwise added TODOs to come back later...
Those were fixed by #2735 iirc
Did a rebase, the one failing test case is fixed in #2759, but you can run the tests locally with `--no-fail-fast` to let it go through all of the other...
@triska that's what I also understood. What I meant earlier was that the CI passing depends on #2759 (as of now, the same error in the CI occurs in `rebis-dev`),...
I couldn't find where the code for adding module specifiers lives in the project (which is currently blocking me on #2738 to cleanly let `strip_module/3` default to the context module...