Goodtime icon indicating copy to clipboard operation
Goodtime copied to clipboard

Feature request: True light theme and "Follow Device" theme switching

Open seankhl opened this issue 3 years ago • 4 comments

Thank you very much for this wonderful, bloat-free app!

I'd like to have a true light theme (white background) and the ability to set the app to follow the device theme (light during the day, dark/amoled at night, but probably the most general solution is to let the user assign any theme they want theme for "day" and "night" modes).

I'm actually happy to help implement this, I am an experienced programmer and I know Java, but I have almost no experience with mobile app development. A nudge in the right direction with respect to how to best implement this for your particular app would probably lead to a PR, if you're interested.

seankhl avatar Jun 30 '21 04:06 seankhl

I'm glad you like it!

You can give it a try if you want to. I'm not sure yet how to handle the existing dark(but not true black) theme.

Here are some links that might help:

  • https://developer.android.com/guide/topics/ui/look-and-feel/darktheme
  • https://material.io/develop/android/theming/dark
  • https://medium.com/androiddevelopers/appcompat-v23-2-daynight-d10f90c83e94

You'll find here a palette(which I plan to extend with more colors):

  • https://github.com/adrcotfas/Goodtime/blob/master/app/src/main/res/values/colors.xml This needs an equivalent for the light theme to have a proper contrast against white.

BTW, I plan to slowly convert the code to Kotlin along with refactoring.

adrcotfas avatar Jul 01 '21 18:07 adrcotfas

What is the status of this FR ? I use Productivity for more than 2 years now, but changing to an e-ink display, dark theme is unfriendly and hard to read with summer daylight 🌞

Rom1deTroyes avatar Jul 20 '22 13:07 Rom1deTroyes

I'd also like to voice my support for this feature. It would make this app a great addition to Android e-ink device users everywhere.

Pherrera0 avatar Jan 22 '24 16:01 Pherrera0

It will come in the next major update.

adrcotfas avatar Jan 22 '24 17:01 adrcotfas