flowchart.js icon indicating copy to clipboard operation
flowchart.js copied to clipboard

Explicit dependencies using require

Open sergeyt opened this issue 8 years ago • 6 comments

Please consider to refactor the package code in favor of explicit dependencies (instead of //= preprocessor comments) using require to support webpack/browserify wrokflows. Also please explicitly require raphael and add it package.json dependencies. FYI raphael master branch already supports browserify. IMHO this change will be very useful.

sergeyt avatar Jan 13 '16 19:01 sergeyt

BTW I've made this PR to make js-sequence-diagrams webpack-friendly.

sergeyt avatar Jan 13 '16 19:01 sergeyt

PR for flowchart.js are welcome too ;-)

adrai avatar Jan 14 '16 06:01 adrai

@adrai I've sent PR #71. What do you think about if I revise build scripts just using webpack without using grunt at all and add npm scripts to package.json?

sergeyt avatar Jan 14 '16 11:01 sergeyt

ok

adrai avatar Jan 14 '16 11:01 adrai

Do you want to be an official contributor?

adrai avatar Jan 14 '16 11:01 adrai

Thank you, but I'm afraid that I will not have enough time as usual. webpack and eslint helps me to quickly made PR #71, but I don't know this code well now. Maybe later I could help to fix few issues.

sergeyt avatar Jan 14 '16 11:01 sergeyt