Results 52 comments of Andrew Raffensperger

That function shouldn't run more than once per blob, of which there are 2. Let me see if I can run this.

There's not enough information here for me to run this, can you provide steps?

I temporarily added an [`deinit()` function](https://github.com/adraffy/ens-normalize.js/blob/main/src/lib.js#L28-L32) and called [`init(); deinit();` in a loop](https://github.com/adraffy/ens-normalize.js/blob/main/test/deinit.js) while observing `process.memoryUsage()` and see no leak. IMO, it very unlikely that there is a leak at...

These steps also don't work: https://framesjs.org/#start-with-framesjs-in-nextjs-in-three-steps `yarn run dev` clearly fails as it was never setup I guess the missing step is: `...in your Next.js app` --- `npm init frames@latest`...

Crazy! I do think we should use foundry when possible but complex tests should stay in TypeScript as the equivalent Solidity is unreadable. I think `namechain/` is pretty good: basically...

not sure if I should PR or just reach out: could you update `adraffy/ens-normalize` to `1.11.0` (Unicode 16.0.0)

I'm not sure I understand the context of that fix. In `ensdomains/namechain`, I want to replace `lib/ens-contracts/contracts/utils/LibMem.sol` with `src/common/utils/LibMem.sol` for all imports (which is local and `@ens/`) And I'm using:...

This also seems to fail with a different error on a different contract (`ETHTLDResolver`), which I think is related to the same problem: `Fail - Unable to verify. Solidity Compilation...

In a batch, the `data` parameter is singular and opaque, but it's context is an array of tokens. The current code assumes the data payload is authorization-like and independent of...

Correct. I also agree having multiple receiver callbacks is a bad design, but fixing it is a breaking change. Whereas `safeBatchTransferFrom` passing it's `data` (when non-empty) to `onERC1155Received` is simply...