Adrien Piquerez

Results 262 comments of Adrien Piquerez

> Either that or do you think it'd be useful to also have space for an error or message? Yes of course. I am just saying that `code` is probably...

That would be great. Also if we change the format of the debug test request we should also add the jvm options (and environment variable) , as was suggested [here](https://github.com/scalameta/metals-feature-requests/issues/239)...

@kpodsiad this new `datakind` will be used in the `debugSession/start` request which is only implemented in Metals for the client-side and the scala-debug-adapter for the server side. And Metals can...

Yes but the sbt implementation is in the sbt-debug-adapter plugin (from scala-debug-adapter repository) whose version is set by Metals, and Metals can also force Bloop version. So all in all...

Well it may not be so easy to implement test selection in Bloop and sbt. So I am probably wrong when saying that we can implement it all before we...

This proposal makes perfect sense to me. In term of implementation I would suggest a slightly different format: ``` case class ScalaTestSuitesResult( items: List[ScalaTestSuitesItem] ) case class ScalaTestSuitesItem( target: BuildTargetIdentifier,...

I think you mean `buildTarget/sources` rather than `buildTarget/dependencySources` here, rigth? The protocol already allows to send/receive source directories rather than individual files. So technically, a build server can respond with...

In sbt we could implement something like this: ```scala case r if r.method == "buildTarget/sources" => val target = ... callback.appendExec(s"bspBuildTargetSources $target", Some(r.id)) callback.appendExec(s"$target / managedSources", None) // trigger the...

> Yes, triggering a build after import is feasible and probably not too disruptive. But if the build then generates new source directories that are not already reported by buildTarget/sources...

In a repo where artifacts have different release cycles, I still think it is a good idea to group them by latest version. The ordering would not make much sense...