keycloak-config-cli icon indicating copy to clipboard operation
keycloak-config-cli copied to clipboard

Alias docker tags without Keycloak minor/patch version

Open daniel-shuy opened this issue 2 years ago • 6 comments

What this PR does / why we need it:

Currently, the format of Docker tags is <keycloak-config-cli version>-<keycloak library version>, e.g. 5.3.1-19.0.1. Since the Keycloak library is backwards compatible to within the same major version, usually the keycloak-config-cli user will want to use the latest minor/patch version of the Keycloak library, without having to manually update the image tag everytime there is a new release.

For each release, in addition to the existing Docker tags (x.x.x-x.x.x), the updated Actions workflow also tags the Docker image with the format x.x.x-x (e.g. 5.3.1-19, latest-19).

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #808

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • [x] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

daniel-shuy avatar Mar 17 '23 09:03 daniel-shuy

Codecov Report

Merging #850 (d5863ef) into main (cc36192) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #850   +/-   ##
=========================================
  Coverage     95.53%   95.53%           
  Complexity     1324     1324           
=========================================
  Files            78       78           
  Lines          4279     4279           
  Branches        477      477           
=========================================
  Hits           4088     4088           
  Misses           91       91           
  Partials        100      100           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Mar 17 '23 09:03 codecov[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jun 16 '23 11:06 sonarqubecloud[bot]

@daniel-shuy thank you for your contribution, we will discuss this with the maintainer. Would you mind rebasing your PR on the current main?

thomasdarimont avatar Oct 11 '23 19:10 thomasdarimont

@thomasdarimont done, thanks!

daniel-shuy avatar Oct 12 '23 16:10 daniel-shuy

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 14 '23 12:10 sonarqubecloud[bot]

Hi @thomasdarimont, any update on this?

daniel-shuy avatar Feb 27 '24 09:02 daniel-shuy

Hi @daniel-shuy,

we've tried to merge your change and unfortunately this resulted in our desired images not to be created any more: https://hub.docker.com/r/adorsys/keycloak-config-cli/tags?name=6.0.0

Because of that we've reverted the change again, which leads to the known tags: https://hub.docker.com/r/adorsys/keycloak-config-cli/tags?name=6.0.2

If you feel like you need the tags you've proposed, there should be a new PR including a working solution, I am sorry that I can't invest time on that topic :(

Best Regards Jonas

FYI: @francis-pouatcha @st3v0rr

jonasvoelcker avatar Jun 17 '24 10:06 jonasvoelcker

Ah, sorry, I made a typo, it should have been steps.keycloak_version.outputs instead of steps.keycloak_version.output. I'll recreate another PR

daniel-shuy avatar Jun 24 '24 10:06 daniel-shuy

Recreated a PR with the fix and some improvements (#1069)

daniel-shuy avatar Jun 24 '24 11:06 daniel-shuy