keycloak-config-cli icon indicating copy to clipboard operation
keycloak-config-cli copied to clipboard

create a json validation schema for the project.

Open Motouom opened this issue 10 months ago • 7 comments

What this PR does / why we need it:

Which issue this PR fixes (optional, in `fixes #1122. will close that issue when PR gets merged): fixes #1122

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • [X] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Motouom avatar Feb 04 '25 08:02 Motouom

Okay @thomasdarimont. I will work on that.

Motouom avatar Feb 06 '25 22:02 Motouom

Hello @thomasdarimont

all the changes requested are resolved already.

Motouom avatar Feb 20 '25 10:02 Motouom

@Motouom did you see my comment about adding an example for using the schema in the example yaml configuration files?

Please add a comment with the schema reference here: https://github.com/adorsys/keycloak-config-cli/blob/main/contrib/example-config/benchmark.yaml

This shows users how to use the schema reference.

thomasdarimont avatar Feb 21 '25 10:02 thomasdarimont

I really needed this feature, but the schema in this PR appears to have issues. it wasn’t able to validate the benchmark.yaml example.

To address this, I created this repository: https://github.com/jwesselink/keycloak-import-schema The main advantage is that the schema generation is reproducible, as it uses the Keycloak OpenAPI specification as its source.

Is this something you'd like to add to this repo? Feel free to use it if you find it helpful.

jwesselink avatar May 09 '25 13:05 jwesselink

I really needed this feature, but the schema in this PR appears to have issues. it wasn’t able to validate the benchmark.yaml example.

To address this, I created this repository: https://github.com/jwesselink/keycloak-import-schema The main advantage is that the schema generation is reproducible, as it uses the Keycloak OpenAPI specification as its source.

Is this something you'd like to add to this repo? Feel free to use it if you find it helpful.

Thank you very much @jwesselink, I will consider what you have done and finish this ticket, then write to you once it is done

Motouom avatar Oct 22 '25 08:10 Motouom

Hello @thomasdarimont @jwesselink @AssahBismarkabah. please review this PR on #1331. i will close this one

Motouom avatar Oct 22 '25 09:10 Motouom

i have created a new PR on #1331.

Motouom avatar Oct 22 '25 09:10 Motouom