keycloak-config-cli icon indicating copy to clipboard operation
keycloak-config-cli copied to clipboard

Fix docker hub link creation for releases

Open BreakBB opened this issue 1 year ago • 1 comments

What this PR does / why we need it: Currently the link generated for the release body has the following format:

https://hub.docker.com/r/adorsys/keycloak-config-cli/tags?name=v5.12.0

However the docker images omit the v-prefix, so these links don't provide any results.

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • [x] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

BreakBB avatar Apr 10 '24 07:04 BreakBB

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Apr 10 '24 07:04 sonarqubecloud[bot]

Hi @BreakBB,

could you please rebase your PRs onto the current main so we can see whether the Github Actions work now?

Best Regards Jonas

jonasvoelcker avatar Jun 06 '24 03:06 jonasvoelcker

Hi @BreakBB,

I managed to merge the current main into your branch and pushed it. The CI-change you did is still invalid: https://github.com/adorsys/keycloak-config-cli/actions/runs/9399408127

The workflow is not valid. .github/workflows/ci.yaml (Line: 289, Col: 17): Unexpected symbol: '('. Located at position 24 within expression: github.ref_name.replace('v', '')

Best Regards Jonas

jonasvoelcker avatar Jun 06 '24 10:06 jonasvoelcker

Hi @francis-pouatcha, would you be so kind to take a look at this change, whether it might do the job or not?

jonasvoelcker avatar Jun 06 '24 11:06 jonasvoelcker

Thanks for actually fixing the issue @jonasvoelcker At a second glance TAG#v indeed looks like the better/correct way.

BreakBB avatar Jun 07 '24 05:06 BreakBB

Hi @BreakBB,

unfortunately our change resulted in an even worse solution: https://github.com/adorsys/keycloak-config-cli/releases/tag/v6.0.0

We have reverted the change so it is the same as before:

https://github.com/adorsys/keycloak-config-cli/releases/tag/v6.0.2

If you feel like we need that change, please try to provide another PR, in my opinion it is not that urgent, right?

Best Regards Jonas

FYI: @francis-pouatcha @st3v0rr

jonasvoelcker avatar Jun 17 '24 10:06 jonasvoelcker

Oh wow, yeah that is absolutely not how it should look like, sorry.

Yeah, it's not urgent at all. I was initially thinking about providing a simple and quick fix. I'll see if I can open a test repository to test the pipeline and find a proper solution.

BreakBB avatar Jun 18 '24 13:06 BreakBB