datasafe icon indicating copy to clipboard operation
datasafe copied to clipboard

fix : path traversal for rootBucket

Open AssahBismarkabah opened this issue 1 year ago • 2 comments

I updated the StaticRoutBucket. If the resourcePath doesn't start with the bucketName, the method will now return the original path to avoid unintentional removal of later bucket name segments

AssahBismarkabah avatar Sep 19 '24 16:09 AssahBismarkabah

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.77%. Comparing base (32d36bc) to head (b1d79e0). Report is 26 commits behind head on develop.

Files with missing lines Patch % Lines
...s/datasafe/storage/impl/s3/StaticBucketRouter.java 75.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #351   +/-   ##
==========================================
  Coverage      86.76%   86.77%           
  Complexity         1        1           
==========================================
  Files            164      164           
  Lines           3348     3350    +2     
  Branches         217      218    +1     
==========================================
+ Hits            2905     2907    +2     
  Misses           309      309           
  Partials         134      134           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 20 '24 09:09 codecov[bot]