pinball icon indicating copy to clipboard operation
pinball copied to clipboard

Build tables separately

Open rzr opened this issue 5 years ago • 23 comments

It would be good to build tables outside sources, using pinconfig ... and maintain them in separate repo

rzr avatar Oct 04 '19 19:10 rzr

Well, as a player, I don't mind. But as an hacker, yes it could be good to be able to test table changes without recompiling.

zezinho42 avatar Dec 04 '19 20:12 zezinho42

the reason is that tables can evolve separately and could be composed of unfree contents

rzr avatar Dec 04 '19 22:12 rzr

Hi dear pinball contributors (@zezinho42, @sergiomb2, @orbea ...)

I have news to share I managed to build the gnu table independently, I am considering to create a new repo that can be used as template can you suggest a better name than "pinball-table-gnu" ?

Beta tests are welcome...

Legacy tables might stay inside pinball main source, but others might evolve on their own repo.

Please help by listing and contacting all pinball data contributors.

Regards and happy EoY

rzr avatar Dec 23 '19 23:12 rzr

you have all table Licenses here: https://github.com/sergiomb2/pinball/blob/master/License.txt

2) gnu table licenses are (GFDL or Free Art or CC-BY-SA) and GPLv3 and
CC-BY-SA (data/gnu/README)
3) hurd table license is GPLv2+ (data/hurd/README.txt)
4) professor table license is GPLv2+ (data/professor2/README.txt)

sergiomb2 avatar Dec 24 '19 01:12 sergiomb2

Beta tests are welcome...

I'd like test it , where is the code ? please

Thanks

sergiomb2 avatar Dec 24 '19 01:12 sergiomb2

Merry #GMass : a #GNU #pinball table to play with #EmiliaPinball on #GnuLinux (more to come)

https://github.com/rzr/pinball-table-gnu#

rzr avatar Dec 25 '19 01:12 rzr

Any feedback ? I also plan to relocate code of hurd table ouside main repo and then eventually make a new release, any important patch that should go to master ?

rzr avatar Dec 30 '19 15:12 rzr

Any feedback ?

Sorry, no time for test here for now...

zezinho42 avatar Dec 30 '19 17:12 zezinho42

The hurd table is no more in master branch does any one want to maintain or co-maintain it like the gnu table ?

rzr avatar Jan 07 '20 18:01 rzr

The hurd table is no more in master branch does any one want to maintain or co-maintain it like the gnu table ?

I think I can do that...

zezinho42 avatar Jan 08 '20 14:01 zezinho42

Thanks @zezinho42 have you checked

https://github.com/rzr/pinball-table-gnu#

let me push similar "work in progress" I have done on hurd table

rzr avatar Jan 08 '20 14:01 rzr

Thanks @zezinho42 have you checked Not yet. It would be handy to have a README file explaining how to build the tables also.

zezinho42 avatar Jan 08 '20 15:01 zezinho42

May also ping @paolo-caroni about this "new" project:

https://github.com/rzr/pinball-table-hurd

I also plan to adopt Debian's pinball package and wish we can also submit those 2 new tables as extra packages.

It would be good to see if I missed any valuable patches.

rzr avatar Jan 08 '20 16:01 rzr

Relate-to: https://github.com/rzr/pinball-table-gnu/issues/3

rzr avatar Jun 01 '20 05:06 rzr

Following: https://github.com/rzr/pinball-table-gnu/issues/3

hi @sergiomb2 , thanks for your comment

let me explain again, I don't see any value "to pollute" the engine source code with assets, we have 2 samples tables I think it's enough, tables can evolve in parallels without relying on upstream.

I made those 2 as examples.

Now there is a 3rd one called house , I am the author of it and I didn't distribute it properly, did you distribuate it into fedora? this one is not based on Free contents so it should be mixed along sources, if you did please let me know before cleaning it up, I can rework it too.

Do you know any other tables ?

rzr avatar Jun 01 '20 20:06 rzr

No, I just know about gnu, hurd, professor (two versions) and tux [1] .

[1] https://github.com/sergiomb2/pinball/tree/master/data

sergiomb2 avatar Jun 20 '20 23:06 sergiomb2

If I don't remember wrong there was an horror table modification of tux table for windows... but I have to check on the old computer that is still in my parents house.

paolo-caroni avatar Jun 21 '20 08:06 paolo-caroni

yea I was the author of this table , some contents are at:

http://rzr.online.fr/games.htm

What about professor2 one

rzr avatar Jan 11 '21 19:01 rzr

Professor 2 is only a graphical improvement of professor, I've never complete the game logic.

paolo-caroni avatar Jan 13 '21 10:01 paolo-caroni

may this merged upstream ?

rzr avatar Jan 13 '21 12:01 rzr

I've added my last version to sergiomb repo... https://github.com/paolo-caroni/pinball/commit/8d6aea8f2f2f4a644d349b3c3d034e7482630d6d

if you want made same effort of Hurd on Professor2 you are obviously welcome. Also you can improve the game logic if you wish (in that case add your name in copyleft notice too).

paolo-caroni avatar Jan 13 '21 12:01 paolo-caroni

one day I'd like copy backgrounds from professor to professor2 and drop professor .

sergiomb2 avatar Jan 13 '21 15:01 sergiomb2

Extra note at:

https://github.com/sergiomb2/pinball/commit/2b3d82b3689a466a03c9be2ea52da27b59805e74

For redhat related issue:

https://bugzilla.redhat.com/show_bug.cgi?id=1290935#

rzr avatar Jan 19 '21 14:01 rzr