temurin-build icon indicating copy to clipboard operation
temurin-build copied to clipboard

Add hsdis support into the build for JDK20+

Open sxa opened this issue 1 year ago • 7 comments

Partial implementation of https://github.com/adoptium/adoptium/issues/213 - limited to Linux only.

sxa avatar Jun 30 '23 13:06 sxa

I'm torn about this PR. I really don't like having the --with-capstone in the build.sh since it's a location that's specific to where we are installing it on our machines from the playbooks (So ideally the logic should all be in linux.sh). 🤔

sxa avatar Oct 05 '23 15:10 sxa

I really don't like having the --with-capstone in the build.sh

Now leaning towards only having it in a if variant=temurin block, although realistically it should probably be a parameter to makejdk-any-platform.sh ...

sxa avatar Oct 05 '23 16:10 sxa

As a first pass this has been modified to put it all in linux.sh and gate it on Temurin and Linux/aaarch64 or Linux/x64 for JDK20+

sxa avatar Oct 05 '23 18:10 sxa

We should probably add a smoke test for this, but it can be done in a future PR.

sxa avatar Oct 05 '23 18:10 sxa

Playbook changes merged and docker images rebuild successfully so this is ready to go subject to approvals.

sxa avatar Oct 10 '23 10:10 sxa

(Last force push was for a rebase)

sxa avatar Oct 10 '23 14:10 sxa

Knocking back to draft following this week's PMC meeting where a decision was made not to include this yet pending further understanding of whether it is really useful for a normal build.

sxa avatar Oct 12 '23 09:10 sxa