temurin-build icon indicating copy to clipboard operation
temurin-build copied to clipboard

Remove xcode switch path commands from build scripts

Open Haroon-Khel opened this issue 2 years ago • 8 comments

Ref https://adoptium.slack.com/archives/C09NW3L2J/p1646743526526249

From the above slack thread, it was determined that a full switch path, /Applications/Xcode.app, can be used for JDK11. Since it is already being used for 8 and 17+, It will be made the default switch path on our build machines via the playbooks (pr incoming). Therefore these commands will not be needed in the build scripts

Haroon-Khel avatar Mar 11 '22 12:03 Haroon-Khel

Thank you for creating a pull request! If you have not done so already, please familiarise yourself with our Contributing Guidelines and FAQ, even if you have contributed to the Adoptium project before. GitHub actions will now run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

github-actions[bot] avatar Mar 11 '22 12:03 github-actions[bot]

LGTM But please make sure the default is set correctly on all build machines before this is merged :-)

@sxa Done. And I dont seem to have permissions to merge this. Could you give me permissions, or could you merge this please. Thanks

Haroon-Khel avatar Mar 11 '22 16:03 Haroon-Khel

jdk8u build

configure: error: Xcode 6, 9-12 is required to build JDK 8, the version found was 13.2.1. Use --with-xcode-path to specify the location of Xcode or make Xcode active by using xcode-select.

(Adjusted comment) @gdams is the github checks running in a completely differnet environment from the machies we have in jenkins in a way that this doesn't work for? Can we pre-select a default compiler in that environment?

sxa avatar Mar 11 '22 16:03 sxa

(Adjusted comment) @gdams is the github checks running in a completely differnet environment from the machies we have in jenkins in a way that this doesn't work for? Can we pre-select a default compiler in that environment?

Yeah I've just pushed a commit

gdams avatar Mar 11 '22 16:03 gdams

Looks like the JDK11u build is genuinely broken after switching:

checking size of int *... 0
configure: error: Cannot continue.
configure: The tested number of bits in the target (0) differs from the number of bits expected to be found in the target (64)
configure exiting with result code 1

gdams avatar Mar 14 '22 08:03 gdams

@gdams I was able to build jdk11 hotspot on build-macstadium-macos1014-x64-2 using the full xcode-select switch path

bash-3.2$ xcode-select --print-path
/Applications/Xcode.app/Contents/Developer

Haroon-Khel avatar Mar 14 '22 16:03 Haroon-Khel

The build did not hit the same error as the github workflow

checking for stdio.h... (cached) yes
checking size of int *... 8
checking for target address size... 64 bits

Haroon-Khel avatar Mar 14 '22 16:03 Haroon-Khel

this has been stale for over a year, converting to "draft", if no longer needed please close.

andrew-m-leonard avatar Apr 03 '24 13:04 andrew-m-leonard