installer icon indicating copy to clipboard operation
installer copied to clipboard

MSI-Installer: Text is cut off and not readable

Open larsen0815 opened this issue 2 years ago • 9 comments

Please provide a brief summary of the bug

The help text for at least one element that can be installed is cut off (notice the "...").

Clipboard-1

Please provide steps to reproduce where possible

  • On Windows, start the installer for Temurin JDK 17
  • Continue until the page where it is possible to select elements to be installed
  • Select "JavaSoft (Oracle) registry keys"
  • See text on the right

Expected Results

Text should be short enough to be fully readable. Or better: Provide a link to a web page that has more information.

Actual Results

Text is cut off (to be precise: something is left out from the middle) and in this form makes no sense at all.

What Java Version are you using?

17

What is your operating system and platform?

No response

How did you install Java?

No response

Did it work before?

No response

Did you test with the latest update version?

No response

Did you test with other Java versions?

No response

Relevant log output

No response

larsen0815 avatar Aug 04 '23 16:08 larsen0815

Using the program "textify", I got this. A little bit too long... Dialog is not resizable.

Overwrites the reg keys HKLM\Software\JavaSoft (Oracle). After uninstallation of Eclipse Temurin, Oracle Java running from PATH "C:\Program Files (x86)\Common Files\Oracle\Java\javapath" does not work. You need to reinstall it to recreate these registry keys

larsen0815 avatar Aug 04 '23 16:08 larsen0815

@gdams - one for the Wix 4 rewrite.

karianna avatar Aug 06 '23 05:08 karianna

As noted here https://github.com/adoptium/installer/blob/ce1b4858058ff90ca5866db66274d05f780170f7/wix/Lang/OpenJDK.Base.fr-fr.wxl.template#L19

Description must be limited to 255 chars (spec that I found somewhere one time) .

This one on en-us is 258 chars after substituting {vendor_branding}) by "Eclipse Temurin" In fr-fr around 256 with {vendor_branding}) replaced by "Eclipse Temurin"

I think I remember that the full text is show when the cursor go in top of the text.

Feel free to propose a shorter description for each language to fit into 255 chars

douph1 avatar Jan 03 '24 10:01 douph1

There is even a validation warning when building the msi: warning SMOK1076 : ICE03: String overflow (greater than length permitted in column); Table: Feature, Column: Description, Key(s): FeatureOracleJavaSoft

image

adipiciu avatar Jan 06 '24 17:01 adipiciu

I shortened the text under 255 length but it still doesn't show properly. image

adipiciu avatar Jan 06 '24 17:01 adipiciu

I propose to shorten the string, so it can fit and also to get rid of the validation warning. If the string cannot fit, it adds ellipsis (...) and you won't understand anything anyway.

@douph1 what do you say? image

adipiciu avatar Jan 06 '24 18:01 adipiciu

I propose to shorten the string, so it can fit and also to get rid of the validation warning. If the string cannot fit, it adds ellipsis (...) and you won't understand anything anyway.

@douph1 what do you say? image

If you just remove Eclipse or Temurin, would that fit?

karianna avatar Jan 07 '24 05:01 karianna

If you just remove Eclipse or Temurin, would that fit?

Eclipse Temurin is a variable {vendor_branding}. But even if I remove that, it still doesn't fit completely.

image

adipiciu avatar Jan 07 '24 07:01 adipiciu

This is the maximum we can fit (159 characters)

image

adipiciu avatar Jan 07 '24 09:01 adipiciu