Common Installer gotcha's (that maybe we can catch)

[gdams]

I've assembled a list of common installer gotchas that have forced us to re-release in the past.

• Eclipse Codesigning service failed to handle MSI's and returned a text file. - Fixed via https://github.com/adoptium/installer/pull/324
• Incorrect vendor name in MSI's. - We had to change the name to Eclipse Foundation and rebuild all MSI's.
• macOS binary wasn't deep signed properly - Fixed via https://github.com/adoptium/temurin-build/pull/2712
• jpackageapplauncher wasn't codesigned on JDK16+ - Fixed via https://github.com/adoptium/ci-jenkins-pipelines/pull/158
• macOS binaries had incorrectly signed jmods. This was fixed by moving the sign job to before the tests.
• macOS M1 installers required rosetta. This was fixed by https://github.com/adoptium/installer/pull/354

[douph1]

Incorrect vendor name in MSI's. - We had to change the name to Eclipse Foundation and rebuild all MSI's.

but https://github.com/adoptium/installer/issues/352 want to change it to "Adoptium" or "Eclipse Adoptium"

?

[douph1]

Ok, I probably miss the "in the past"