Allow UCL sign option for Windows installer

[AdamBrousseau]

Related adoptium/temurin-build#2525

Signed-off-by: Adam Brousseau [email protected]

[AdamBrousseau]

Have tested this for the new code path on my farm. Added param to create_windows_installer job for SIGN_TOOL. Reccomend Adopt tests as well.

[douph1]

What is the meaning of adding dedicated code that is not used by temurin build farm ? If we want something extensible maybe another approach without limiting to UCL will be better

something like :

if exists sign.cmd ( call sign.cmd ) else ( signtool.exe... )

and sign.cmd can reuse all the parent var he want to sign

[karianna]

What is the meaning of adding dedicated code that is not used by temurin build farm ? If we want something extensible maybe another approach without limiting to UCL will be better

something like :

if exists sign.cmd ( call sign.cmd ) else ( signtool.exe... )

and sign.cmd can reuse all the parent var he want to sign

As a philosophy, we're happy to accept changes that help other folks who use our build scripts (as long as they are not detrimental to the temurin builds). Using extensibility is a good idea here :-)

[gdams]

@AdamBrousseau is this still required?

[AdamBrousseau]

Well we have the changes on our fork. Ideally we upstream as many of our changes as possible. Prevents merge conflicts and contributes our work back to the community.