infrastructure icon indicating copy to clipboard operation
infrastructure copied to clipboard

unixPB: improves `Ant-Contrib` role compatibility

Open mahdipub opened this issue 1 year ago • 4 comments

It helps improve Ant-Contrib role by replacing wget with get_url module. Also when extracing, on macos the unarchive module might fails as it asks for gtar but default macos tar is bsdtar. The workaround is to run it as command on macos machines.

Signed-off-by: [email protected]

Checklist
  • [x] commit message has one of the standard prefixes
  • [ ] faq.md updated if appropriate
  • [ ] other documentation is changed or added (if applicable)
  • [ ] playbook changes run through VPC or QPC (if you have access)
  • [ ] VPC/QPC not applicable for this PR
  • [ ] for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

mahdipub avatar Sep 30 '24 01:09 mahdipub

@mahdipub linter failures

karianna avatar Sep 30 '24 02:09 karianna

Given the comment above the line, This needs to be tested on Solaris before it can be approved. VPC run at https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1969/

sxa avatar Sep 30 '24 12:09 sxa

@mahdipub linter failures

Thanks, that's resolved.

mahdipub avatar Sep 30 '24 17:09 mahdipub

Given the comment above the line, This needs to be tested on Solaris before it can be approved. VPC run at https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1969/

Don't see Solaris as part of that run?

karianna avatar Oct 01 '24 00:10 karianna

Given the comment above the line, This needs to be tested on Solaris before it can be approved. VPC run at https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1969/

Don't see Solaris as part of that run?

😕 Solaris10 is in there and green

image

sxa avatar Nov 28 '24 11:11 sxa

Tagging in @gdams for a review since he put in the use of wget for Solaris as part of https://github.com/adoptium/infrastructure/pull/1585 but maybe the underlying problem was resolved in more recent versions of ansible

sxa avatar Dec 03 '24 13:12 sxa

New VPC run: https://ci.adoptium.net/job/VagrantPlaybookCheck/2149/

sxa avatar Sep 02 '25 11:09 sxa

New VPC run: https://ci.adoptium.net/job/VagrantPlaybookCheck/2149/

@mahdipub Assuming you still want to get this in, can you rebase your changes on top of master as there's some fixes we need in there to be able to run these checks

sxa avatar Sep 02 '25 14:09 sxa

@sxa that is done.

mahdipub avatar Sep 02 '25 14:09 mahdipub

Running another VPC at https://ci.adoptium.net/job/VagrantPlaybookCheck/2150/

sxa avatar Sep 02 '25 15:09 sxa

VPC looks good

Noting that VPC doesn't cover mac @Haroon-Khel ;-)

sxa avatar Sep 23 '25 13:09 sxa

Noting that VPC doesn't cover mac @Haroon-Khel ;-)

The MacOS 14 github check ran the mac changes fine. However during my recent MacOS 15 testing, ive been installing ant-contrib via brew which is much easier, might change it in the playbooks to that when I get the time

Haroon-Khel avatar Sep 23 '25 14:09 Haroon-Khel

/thaw

Haroon-Khel avatar Sep 23 '25 14:09 Haroon-Khel

Sorry @Haroon-Khel, the code freeze is still in place.

github-actions[bot] avatar Sep 23 '25 14:09 github-actions[bot]

/merge

karianna avatar Sep 24 '25 09:09 karianna

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

github-actions[bot] avatar Sep 24 '25 09:09 github-actions[bot]

/approve

karianna avatar Sep 24 '25 09:09 karianna

Any reason this needs to be merged during the code freeze?

jerboaa avatar Sep 24 '25 09:09 jerboaa

Any reason this needs to be merged during the code freeze?

No, and we've ended it now anyway ;-)

/thaw

(That probably won't work in the middle of another comment)

sxa avatar Sep 24 '25 16:09 sxa

/thaw

sxa avatar Sep 25 '25 08:09 sxa