infrastructure icon indicating copy to clipboard operation
infrastructure copied to clipboard

Update GitHub actions: [upload|download]-artifact v1|v2|v3

Open jiekang opened this issue 1 year ago • 2 comments

An email was sent to [email protected] titled:

[eclipse.org-committers] Deprecation Warning for GitHub actions [upload|download]-artifact v1|v2|v3

With call to update the following GitHub actions to v4 or later:

  • actions/upload-artifact
  • actions/download-artifact

The following versions are deprecated and will stop working in the not so near future:

  • v1 and v2: from 30/06/2024
  • v3: from 30/11/2024

See the following searches for instances of these actions in the Adoptium organization.

Code search for upload-artifact: https://github.com/search?q=org%3Aadoptium%20actions%2Fupload-artifact&type=code

Code search for download-artifact: https://github.com/search?q=org%3Aadoptium+actions%2Fdownload-artifact&type=code

jiekang avatar Apr 24 '24 13:04 jiekang

The majority of the upload-artifact query hits are false positives.

  • many are in the mirrored OpenJDK repositories (i.e., adoptium/jdk8u, adoptium/jdk11u, etc.) and these are not used, and are configured not to be run, by the Adoptium project.
  • others are in documentation .md and .adoc files and are not run.

Those that are in .yml files that are run by the project are already at v4 level so are not part of the notice. The two .yml files that are run and are currently at v3 have been updated via the PRs linked above.

tellison avatar Apr 24 '24 15:04 tellison

All the download-artifacts query hits are false positives.

  • most are in the mirrored OpenJDK repositories (i.e., adoptium/jdk8u, adoptium/jdk11u, etc.) and these are not used, and are configured not to be run, by the Adoptium project.
  • one .yml file is an example not run by the project.

tellison avatar Apr 24 '24 15:04 tellison

Just came across this issue - do we believe further action needs to occur here or can this be closed @tellison @jiekang ?

sxa avatar Jul 28 '25 13:07 sxa

I think it can be closed. Tim reviewed and fixed things everything at the time. I just did a second glance and don't see anything glaring. Also based on the deprecation dates, I'm sure, if we actually needed it, we would have fixed everything that was broken when it broke.

jiekang avatar Jul 28 '25 19:07 jiekang