containers
containers copied to clipboard
adoptium
Refactor dockerfile_functions.sh in their own architecture specific files
@karianna is any summary of https://adoptium.slack.com/archives/CSJ203YTW/p1612259867007300 available ? Also I would like to challange a bit idea of having this in bash instead, let's say python and jinja ? It seems the scripts want to behave like a templating engine to generate Dockerfile's, why not to use more apriopriate tooling ?
https://github.com/adoptium/containers/issues/1 covers most of the conversation that's still partly ongoing (we need to summarise it and then update the README for everyone).
bash is common across all our supported platforms but if you were happy to re-write the scripts in Python we could discuss that for sure.
@karianna after my last issue was merged I started looking for something else I could contribute to this project. Hence I ended up here.
In your comment you mention that "bash is common across all our supported platforms", however in the ticket related to refactoring common_functions.sh (#6 ) you raise the point that python3 is used to parse JSON. So it would be appear that python3 is also supported (and even required) across all the platforms. Would this help motivate a move towards replacing bash with Python 3?
That’s a great question and one to ask in the infrastructure channel on slack. They have th elbow ledge of all of our H/W and O/S combinations
On Thu, 25 Nov 2021 at 12:15, Philipp Gerhard @.***> wrote:
@karianna https://github.com/karianna after my last issue was merged I started looking for something else I could contribute to this project. Hence I ended up here.
In your comment you mention that "bash is common across all our supported platforms", however in the ticket related to refactoring common_functions.sh (#6 https://github.com/adoptium/containers/issues/6 ) you raise the point that python3 is used to parse JSON. So it would be appear that python3 is also supported (and even required) across all the platforms. Would this help motivate a move towards replacing bash with Python 3?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adoptium/containers/issues/8#issuecomment-979159502, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABME2DORHYB22P5EPIA7RLUNYSGVANCNFSM5B3Z3AMQ .
-- Cheers, Martijn (Sent from Gmail Mobile)
Python is likely the best option, I'd considered using Python and handlebars to template the Dockerfiles going forwards
