sign_build job should be more configurable

[AdamBrousseau]

Related/Similar AdoptOpenJDK/ci-jenkins-pipelines#50

https://github.com/AdoptOpenJDK/openjdk-build/blob/282058709909733381464dcb67b7f0d13dca4e13/pipelines/build/common/openjdk_build_pipeline.groovy#L226

The function for sign build has some hardcoded values which could be parameterized to make the scripts more portable.

Lables

https://github.com/AdoptOpenJDK/openjdk-build/blob/282058709909733381464dcb67b7f0d13dca4e13/pipelines/build/common/openjdk_build_pipeline.groovy#L237 def nodeFilter = "${buildConfig.TARGET_OS}"

https://github.com/AdoptOpenJDK/openjdk-build/blob/282058709909733381464dcb67b7f0d13dca4e13/pipelines/build/common/openjdk_build_pipeline.groovy#L242 nodeFilter = "${nodeFilter}&&build&&win2012"

https://github.com/AdoptOpenJDK/openjdk-build/blob/282058709909733381464dcb67b7f0d13dca4e13/pipelines/build/common/openjdk_build_pipeline.groovy#L248 nodeFilter = "${nodeFilter}&&macos10.14"

Certificates

https://github.com/AdoptOpenJDK/openjdk-build/blob/282058709909733381464dcb67b7f0d13dca4e13/pipelines/build/common/openjdk_build_pipeline.groovy#L241 certificate = "C:\\openjdk\\windows.p12"

https://github.com/AdoptOpenJDK/openjdk-build/blob/282058709909733381464dcb67b7f0d13dca4e13/pipelines/build/common/openjdk_build_pipeline.groovy#L246 certificate = "\"Developer ID Application: London Jamocha Community CIC\""

[AdamBrousseau]

Not sure why this wasn't handled in #145. This issue is still valid even though the code has changed.

IMO this line should be configurable https://github.com/adoptium/ci-jenkins-pipelines/blob/c5a5ed7dd940b95951dc3379fb73605c5f31f013/pipelines/build/common/openjdk_build_pipeline.groovy#L404

[SehrishHussain]

@andrew-m-leonard can we work on this issue?

[andrew-m-leonard]

@SehrishHussain yes, this looks like a new BUILD_CONFIG parameter is required for nodeFilter, which in turn can then be specified via the Jenkins build job params

[SehrishHussain]

@andrew-m-leonard please check the PR looking forward for your feedback

[cornelia247]

@andrew-m-leonard I am interested in this issue can it be assigned to me?

[andrew-m-leonard]

Thanks @cornelia247 , i've assigned it to you.