ci-jenkins-pipelines icon indicating copy to clipboard operation
ci-jenkins-pipelines copied to clipboard

Attempting to build from an openjdk branch no longer works

Open sxa opened this issue 2 years ago • 4 comments

What are you trying to do? Build from a branch of hotspot in order to test a fix: https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk/job/jdk-aix-ppc64-hotspot/638/console

Expected behaviour: VARIANT=hotspot with -r and -b settings for BUILD_ARGS work properly as per the FAQ

Observed behaviour:

Loading library openjdk-jenkins-helper@null
Examining [adoptium/jenkins-helper](https://github.com/adoptium/jenkins-helper)
Attempting to resolve null as a branch
Attempting to resolve null as a tag
ERROR: Could not resolve null
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
ERROR: No version null found for library openjdk-jenkins-helper
Finished: FAILURE

Any other comments: This was using the -hotspot job instead of -temurin so it's possible this is the result of not regenerating the -hotspot jobs. We'll need to check the implications on the other variants that we build if this is the case.

In fact, this seems to make no difference whether the fork/branch option are specified as it "breaks" with the default parameters on the hotspot jobs too https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk/job/jdk-aix-ppc64-hotspot/640/console

Possibly related to https://github.com/adoptium/ci-jenkins-pipelines/pull/496 @zdtsw @andrew-m-leonard

sxa avatar Nov 15 '22 12:11 sxa

looks like the job is missing HELPER_REF BUILD_REF and CI_REF

from https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk/job/jdk-aix-ppc64-hotspot/build?delay=0sec Screenshot from 2022-11-15 14-07-01

compare with https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk/job/jdk-alpine-linux-x64-temurin/build?delay=0sec Screenshot from 2022-11-15 14-07-41

zdtsw avatar Nov 15 '22 13:11 zdtsw

and this job is not generated by https://ci.adoptopenjdk.net/job/build-scripts/job/utils/job/pipeline_jobs_generator_jdk/ ?

do we have a list of all the manual created jobs? these all need to be updated with new parameters.

zdtsw avatar Nov 15 '22 13:11 zdtsw

@sxa @zdtsw The above is a "hotspot" build not a "temurin" one, the change only changed the "temurin" template I suspect

andrew-m-leonard avatar Nov 15 '22 15:11 andrew-m-leonard

temurin is the only jdk-20 target configuration: https://github.com/adoptium/ci-jenkins-pipelines/blob/5d694972320e48bb3f5e12fbacef496f55ef5617/pipelines/jobs/configurations/jdk20.groovy#L17

andrew-m-leonard avatar Nov 15 '22 15:11 andrew-m-leonard