ci-jenkins-pipelines icon indicating copy to clipboard operation
ci-jenkins-pipelines copied to clipboard

OpenJ9 builds should pass OpenJ9 SHA to test

Open AdamBrousseau opened this issue 3 years ago • 2 comments

For OpenJ9 builds, the openj9 sha used to compile the SDK should be passed to test. Sometimes there are code changes with matching test changes. If such a change is merged "mid-flight" (ie. After a compile starts but before a test starts), the test job would pickup the change and could cause failure. This has happened in eclipse-openj9/openj9#12629 for example.

AdamBrousseau avatar May 05 '21 21:05 AdamBrousseau

is this still a valid issue?

zdtsw avatar Sep 15 '22 11:09 zdtsw

I think this is valid. In addition, I think we should do a sniff for all test-related repos and pass all test repo SHAs to test builds to ensure we are running the same test materials in one pipeline. Otherwise, we would have a similar problem. If a PR is delivered between test builds, we could end up running different test materials in the same pipeline.

FYI @smlambert

llxia avatar Sep 15 '22 14:09 llxia