ci-jenkins-pipelines
ci-jenkins-pipelines copied to clipboard
adoptium
Added JMH to be also built by code-tools
JMH is another code-tools openjdk project which release pretty randomly. JMH suite itslef is engine to run benchamrks, and reelased versions are apearing in maven repos (similarly as jcstress). JMH samples can be used as pretty good testsuite when reduced to run minimal iterations.
Generally spoken the build of TIP is heavily missed world wide.
Thank you for creating a pull request!
Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).
Code Quality and Contributing Guidelines
If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.
Tests
Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.
In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Is this actually required. Aleksey regularly releases this upstream
I wish it is not requored:(
https://github.com/openjdk/jmh/tags - year ago followed by https://github.com/openjdk/jmh/tags
But true - latest released is brobably not necessary. only tip.
Actually one reason to build both master and latest released - if the build of tip fails, it may behard to say it it is jdk or jmh who isguilty. If fails latest released, then it is most likely jdk.
Is this still in progress as jenkinsfile also need to update if we'd like to build here?
Is this still in progress as jenkinsfile also need to update if we'd like to build here?
Nope. sorry. I forget about it.
@karianna @gdams Where shipilev.net is reliable build system, it is still private machine. However adoptium is trusted provider. Even the jmh on maven repos is till build on someones lcoalhost. Thus saying, we should be building JMH. Both latest release, and tip. in addition, tip is nowehre esle to be found
The overwhemling majority of users consume JMH through Maven Central releases. So, unless you are planning to publish SNAPSHOT versions somewhere, I see no particular value in building JMH separately in Adoptium. I see no particular cost for it either, so it is your choice, really.
