aqa-tests icon indicating copy to clipboard operation
aqa-tests copied to clipboard

Remove native compiler dependency in system tests

Open llxia opened this issue 8 months ago • 4 comments

Native compilation in system tests resulted in many complications when setting up the testing environment.

For example, we need to have the correct compiler installed. xlC is /opt/IBM/xlC/13.1.3/bin (we no longer support it), but it's on the path. xlclang is /opt/IBM/xlC/16.1.0/bin, which isn't on the path. Also, Visual Studio is expected on Windows with specific versions/path.

Talked with @pshipton , and we think we should simplify system tests by removing the native compiler dependency.

ToDo:

  • [x] Remove com.test.jlink from system test https://github.com/adoptium/aqa-systemtest/tree/master/openjdk.test.modularity/src/tests/com.test.jlink. If this test is important, we can contribute it to OpenJDK if needed.
  • [ ] Move SharedClassesAPI native code into OpenJ9, and stop building it in the tests. https://github.com/adoptium/aqa-tests/blob/9776620cc838d27813365c534a2639a5dced4b92/system/sharedClasses/playlist.xml#L26
  • [ ] Ensure we do not have any other native compilation in system tests (i.e., all build-natives-xxx should be empty)
  • [ ] ~Inform infra team to remove native compiler as part of the test env setup requirement.~ We still need it for non-system tests.

llxia avatar Feb 20 '25 21:02 llxia