aqa-tests icon indicating copy to clipboard operation
aqa-tests copied to clipboard

Refine exclude files logic

Open llxia opened this issue 11 months ago • 3 comments

New exclude files (for openjdk, functional, etc) have to be created for the new JDK version regardless of whether we have any new changes. See https://github.com/eclipse-openj9/openj9/issues/17901.

I think we should have a common exclude file. A new exclude file only needs to be created if there are any specific excludes for particular JDK version.

llxia avatar Jan 21 '25 20:01 llxia

I'd think for OpenJ9 we always have jdk version openjdk specific excludes for any new version. Although perhaps they are temporary while we bring up the new version and when temporary excludes are later removed the exclude list might be the same as the previous version.

pshipton avatar Jan 21 '25 20:01 pshipton

Yes, for openjdk test we always have jdk version-specific excludes. A common exclude file could reduce the work of copying common ones and ensure the test build does not break if version-specific exclude does not exist.

The proposed solution is to have a common exclude file + an optional version-specific exclude.

This issue is mainly targeted at these duplicated exclude files (no new excludes). Currently, we have to create the file for each version regardless. Otherwise, the test build will break. https://github.com/eclipse-openj9/openj9/tree/master/test/functional/cmdLineTests/jvmtitests https://github.com/eclipse-openj9/openj9/tree/master/test/TestConfig/resources/excludes

FYI @JasonFengJ9

llxia avatar Jan 22 '25 02:01 llxia

@LongyuZhang could you work on this one? Let's start with functional tests. There are some details mentioned in https://github.com/eclipse-openj9/openj9/issues/17901

llxia avatar Jan 31 '25 14:01 llxia