aqa-tests icon indicating copy to clipboard operation
aqa-tests copied to clipboard

jcstress dependencies are unclear

Open judovana opened this issue 10 months ago • 3 comments

The getDepenencies is pulling jcstress-tests-all-20240222.jar' https://github.com/adoptium/TKG/blob/master/scripts/getDependencies.pl#L182 in addition, it is pulling it from personal server

however, the https://github.com/adoptium/aqa-tests/blob/master/system/jcstress/playlist.xml is using jcstress-tests-all-20220908.jar

The 20220908 is nowhere to be obtained, so unless it is manually in $(LIB) it fails.

I would like to do following changes:

  • improve https://ci.adoptium.net/view/Dependencies/job/dependency_pipeline/lastSuccessfulBuild/artifact/jcstress/ so it builds jcstress-tests-all-20220908.jar and jcstress-tests-all-20240222.jar and tip
  • change getDependencies.pl so it is pulling three jcstress jars from https://ci.adoptium.net/view/Dependencies/job/dependency_pipeline/lastSuccessfulBuild/ instead of https://builds.shipilev.net/jcstress/
  • improve https://github.com/adoptium/TKG/blob/master/scripts/getDependencies.xml so it have target, which will prepare jcstress.jar per JDK version, as jtregs are doing it.
  • improve https://github.com/adoptium/aqa-tests/blob/master/system/jcstress/playlist.xml so it is using jcstress jar per jdk version
    • I would like to use 20240222 everywhere where possible. Use 20220908 as fallback, and maybe use tip for future jdk
  • if possible, I would like to revisit targets in https://github.com/adoptium/aqa-tests/blob/master/system/jcstress/playlist.xml so they enumeare all possible targets (based on version of jcstress?). But tbh, I had not yet properly looked into it.

WDYT?

judovana avatar Apr 24 '24 12:04 judovana

  • Update https://ci.adoptium.net/view/Dependencies/job/dependency_pipeline/lastSuccessfulBuild/artifact/jcstress/ so it builds jcstress-tests-all-20220908.jar and jcstress-tests-all-20240222.jar and tip

Raised https://github.com/adoptium/ci-jenkins-pipelines/issues/1016 for this

  • Update getDependencies.pl in TKG so it is pulling three jcstress jars from https://ci.adoptium.net/view/Dependencies/job/dependency_pipeline/lastSuccessfulBuild/ instead of https://builds.shipilev.net/jcstress/

Will raise an issue in TKG for this

  • Update https://github.com/adoptium/TKG/blob/master/scripts/getDependencies.xml so it have target, which will prepare jcstress.jar per JDK version, as jtregs are doing it.
  • improve https://github.com/adoptium/aqa-tests/blob/master/system/jcstress/playlist.xml so it is using jcstress jar per jdk version

These 2 bullets may end up being the same task. Think this could be accomplished best by updating system.mk or system/build.xml, or again making a shared target in an ant script in TKG, needs thought/discussion and agreed upon documented plan before proceeding

  • if possible, I would like to revisit targets in https://github.com/adoptium/aqa-tests/blob/master/system/jcstress/playlist.xml so they enumare all possible targets. But tbh, I had not yet properly looked into it.

This can be an issue in aqa-tests repo when we get to it.

smlambert avatar Apr 24 '24 14:04 smlambert

ok. ty!

judovana avatar Apr 24 '24 15:04 judovana

For easy maintenance, see TKG issue Remove 3rd party jar version in fname

llxia avatar May 02 '24 12:05 llxia