aqa-tests icon indicating copy to clipboard operation
aqa-tests copied to clipboard

Fix spaces in ProblemList files

Open smlambert opened this issue 1 year ago • 0 comments

When a set of platforms are provided as a comma-separated list in the ProblemList files for openjdk tests, there must not be spaces or else the trailing platforms will be ignored.

We should check all ProblemList files for any of these (and add to the disabled tests checker, if its not already there).

One case that needs to be fixed is found on https://github.com/adoptium/aqa-tests/blob/master/openjdk/excludes/ProblemList_openjdk17.txt#L167

java/io/File/GetXSpace.java https://bugs.openjdk.java.net/browse/JDK-8251466 windows-all, linux-arm, aix-all

needs to be changed to

java/io/File/GetXSpace.java https://bugs.openjdk.java.net/browse/JDK-8251466 windows-all,linux-arm,aix-all

The test case in question is still being run on arm_linux, despite it appearing as though its been excluded. The exclusion is being ignored by jtreg due to the spaces. This needs to be corrected.

Related: https://github.com/adoptium/aqa-tests/issues/5211


To reiterate, to fix this issue, we should:

  1. Fix ProblemList_openjdk17.txt#L167 to remove the spaces
  2. Check for extra spaces in problem list files in the scripts/disabled_tests/exclude_parser.py and alert if they present

smlambert avatar Apr 16 '24 01:04 smlambert