aqa-tests icon indicating copy to clipboard operation
aqa-tests copied to clipboard

Add a Mockito Testcase

Open babsingh opened this issue 1 year ago • 5 comments

There are two OpenJ9 user issues where a crash with Mockito is reported:

  • https://github.com/eclipse-openj9/openj9/issues/18750
  • https://github.com/eclipse-openj9/openj9/issues/18781

The Mockito test case will help us identify the above crashes in our builds.

Test case variant 1: https://github.com/eclipse-openj9/openj9/files/13920987/reproApp.tar.gz

Test case variant 2: https://github.com/eclipse-openj9/openj9/files/13989201/segmentationerror.zip

Dependencies:

  • Mockito jar: https://repo1.maven.org/maven2/org/mockito/mockito-core
  • Bytebuddy
  • Maven

Not all dependencies might be needed; and test case variant 2 is simpler and relies on fewer dependencies.

Guidance based on the discussions with the test team:

  • The test should be added in https://github.com/adoptium/aqa-tests/tree/master/functional since it can be run with both OpenJ9 and OpenJDK.
  • We can create an folder MockitoTests.
  • We do not need testng in this case.
  • We need build.xml, playlist.xml, and the test case.
  • Sample example: https://github.com/eclipse-openj9/openj9/tree/master/test/functional/TestExample.
  • 3rd party jars should to be added in adoptium/TKG/scripts/getDependencies.pl#L66-L176.
  • Licences of 3rd party jars should be verified before including them into TKG:
    • Mockito: https://github.com/mockito/mockito/blob/main/LICENSE
    • Byte-buddy: https://github.com/raphw/byte-buddy/blob/master/LICENSE

babsingh avatar Feb 15 '24 22:02 babsingh